alexanderluiscampino / lambda-layers

Several layers for AWS Lambda
32 stars 15 forks source link

Layer for Python 3.9 #3

Closed nayaverdier closed 1 year ago

nayaverdier commented 1 year ago

I have been using your layer for python 3.7, and it's been a massive lifesaver. I'm having difficulty building a similar layer for python 3.9. Do you have one already built somewhere, or instructions that might help to build it?

alexanderluiscampino commented 1 year ago

I dont right now, last time I tried I failing creating the binding. But I can put sometime on that soon to be honest.

nayaverdier commented 1 year ago

@alexanderluiscampino I just got a 3.9 layer working by taking your 3.7 layer, and replacing the python directory with output of running pip install pyodbc==4.0.26 -t python on the docker image public.ecr.aws/sam/build-python3.9:latest.

For some reason using the latest pyodbc version did not work properly, it just wasn't picking up the driver at runtime.

Let me know if you'd like me to make a PR to add pyodbc39.zip

alexanderluiscampino commented 1 year ago

Thats awesome, sorry have been on vacation haven't had the time to try it.

Would you mind opening a PR? I'd also like to ask to add whatever script you used, so I can replicate on my end. I intend to have a recipe to create these layers.

You didn't have to modify the ini files at all for it to work?

nayaverdier commented 1 year ago

Nope, I didn't have to modify the ini files at all! I just opened the PR and included the steps to build there.

alexanderluiscampino commented 1 year ago

Ah, I see why. You're reusing the 3.7 files and just overwriting for 3.9 using your script. Smart.

On Wed, Nov 9, 2022, 06:50 nayaverdier @.***> wrote:

Nope, I didn't have to modify the ini files at all! I just opened the PR and included the steps to build there.

— Reply to this email directly, view it on GitHub https://github.com/alexanderluiscampino/lambda-layers/issues/3#issuecomment-1308880046, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHX6VAY7EMDXURUDKHNHHW3WHO24ZANCNFSM6AAAAAARXVBMIQ . You are receiving this because you were mentioned.Message ID: @.***>