search

alexandermarston / vnstat-dashboard

A responsive web UI to view network traffic statistics provided by vnStat (with support for version 2.x)
https://alexandermarston.github.io/vnstat-dashboard/
142 stars 60 forks source link

fixes #14 #15

Closed mkingbe closed 5 years ago

mkingbe commented 5 years ago

14

alexandermarston commented 5 years ago

@mkingbe

The code doesn't seem to be too happy.

[root@nexus vnstat]# php --version PHP 5.4.16 (cli) (built: Apr 12 2018 19:02:01) Copyright (c) 1997-2013 The PHP Group Zend Engine v2.4.0, Copyright (c) 1998-2013 Zend Technologies

[root@nexus vnstat]# php index.php PHP Parse error: syntax error, unexpected '>' in vnstat.php on line 181

mkingbe commented 5 years ago

The dockerfile said that the project runs on php-7. The changes made by me are compatible with php 7.0 and above.

alexandermarston commented 5 years ago

Hi @mkingbe thanks for your PR - good point, I didn't realise the Dockerfile had the version set to 7.

I've made your changes myself in such a way that they'll still be compatible with version 5.4.

I don't believe we need this PR open anymore.