search

alexandermarston / vnstat-dashboard

A responsive web UI to view network traffic statistics provided by vnStat (with support for version 2.x)
https://alexandermarston.github.io/vnstat-dashboard/
142 stars 60 forks source link

Migrate to object oriented php #20

Closed alexandermarston closed 5 years ago

alexandermarston commented 5 years ago

The code base should be migrated to an object oriented style of code.

dangenendt commented 5 years ago

I can do that. Anything against using a template engine like Twig/Blade/Smarty for the html stuff? Using one of them would bring the "need" for composer (con because of a little more complexity of the application)... but with composer and the change to an object-oriented style you don't need to worry about autoloading then (pro) ;).

alexandermarston commented 5 years ago

Sounds good to me, @dangenendt

Nothing against using a template engine - happy with the need for composer.

dangenendt commented 5 years ago

Nice! WIP

thgs commented 5 years ago

Oh and I had started on that, was wondering how he would like to see the implementation.

alexandermarston commented 5 years ago

@thgs more than happy to see multiple examples of an implementation of this!

thgs commented 5 years ago

I was wondering if you want composer in the project actually. I am trying to do something lite without composer so far.

alexandermarston commented 5 years ago

@thgs I've not got a specific requirement to have something using Composer. If you can provide a good solution without it then definitely happy to take a look.

alexandermarston commented 5 years ago

As of 5a97b0c the code base has been refactored to take advantage of an object oriented style of code.

The project is now also using Smarty as a template engine.

Issue closed.