search

alexandermarston / vnstat-dashboard

A responsive web UI to view network traffic statistics provided by vnStat (with support for version 2.x)
https://alexandermarston.github.io/vnstat-dashboard/
142 stars 60 forks source link

simple convert to OOP #21

Closed thgs closed 5 years ago

thgs commented 5 years ago

heres my attempt

thgs commented 5 years ago

however i wouldn't like it to merge before @dangenendt PR, as he said he is working on it and I had notified nobody so..

dangenendt commented 5 years ago

@thgs Your simple approach is absolutely fine. The only thing what seems a little werid to me is the name of "index2.php" :nerd_face: I didnt tested it yet (at work right now), but if its working we can merge that.

alexandermarston commented 5 years ago

@dangenendt waiting on your PR before any merge.

dangenendt commented 5 years ago

No no no. You can merge it. I just started with bringing in composer and some other smaller stuff. Didnt touched the "old codebase" yet. Means, when you merge it i could build some further refactorings upon this branch here :+1:

thgs commented 5 years ago

Cant merge it yet. My bad. I pulled upstream to resolve conflicts and seems also I forgot to require helpers.php. I think I would like to separate VNStat completely and create a View class to resolve that ugly index2.php @dangenendt @alexandermarston

thgs commented 5 years ago

Now its good to go, I think.

alexandermarston commented 5 years ago

This PR has been superseeded and is no longer required.

Thanks for the contribution, if you have anything else please raise another PR!