Refactor vnstat - Githubissues

alexandermarston / vnstat-dashboard

A responsive web UI to view network traffic statistics provided by vnStat (with support for version 2.x)

142 stars 60 forks source link

Open AllanKlaus opened 5 years ago

AllanKlaus commented 5 years ago

Motivation The function getVnstatData is very complex. I created a function generateGraph that perform the same of 4 foreachs on that function getVnstatData.
Issue: #14

alexandermarston commented 5 years ago

I'm getting the following error:

PHP Fatal error: Cannot pass parameter 4 by reference in /var/www/vnstat/vnstat.php on line 119

AllanKlaus commented 5 years ago

I updated it. Maybe could be another way to do it and i'm not seeing it now.

I added a var $top10Graph and after I do a unset to remove it