search

alexandermarston / vnstat-dashboard

A responsive web UI to view network traffic statistics provided by vnStat (with support for version 2.x)
https://alexandermarston.github.io/vnstat-dashboard/
142 stars 60 forks source link

fixed #31

Closed cremesk closed 4 years ago

cremesk commented 5 years ago

Compare: Refactor vnstat #22 and Fixed infinite loop #24

alexandermarston commented 5 years ago

@cremesk can you please rebase your branch with the latest changes. Thanks

cremesk commented 5 years ago

okay is fixed.

alexandermarston commented 5 years ago

@cremesk you should avoid using shell_exec where you don't have to.

Alternatively, to get a hostname you could use gethostname / php_uname

http://php.net/manual/en/function.gethostname.php

cremesk commented 5 years ago

preview: https://vpn13.freifunk-dresden.de/vnstat/

cremesk commented 5 years ago

@alexandermarston can you pls merge my Pull-Request? :)

alexandermarston commented 5 years ago

@cremesk In the code it appears you are generating a graph for the Top 10 days, but I cannot see that being used anywhere.

In addition, on your site I cannot see the Top 10 table being populated either.

cremesk commented 5 years ago

@AllanKlaus you have a Solution?

AllanKlaus commented 5 years ago

No idea, need to debug better. Looking superficially it apper that the error is in the function kbytesToString. But it could not be.

cremesk commented 4 years ago

outdated