Replace PhantomJS with Puppeteer

alexandervalencia / github-issues-to-pdf

GitHub Issues to PDF Exporter using Puppeteer

MIT License

17 stars 9 forks source link

Replace PhantomJS with Puppeteer #13

Closed N1ck closed 5 years ago

N1ck commented 6 years ago

Addresses: https://github.com/alexandervalencia/github-issues-to-pdf/issues/12

Replaces the use of PhantomJS with Puppeteer. The other change was to create the directory to save PDFs to, this isn't done automatically by Puppeteer.

I tested locally with a number of different users/organisations and results were 👌

alexandervalencia commented 5 years ago

Just started reviewing :)

:octocat: Sent from GH.

alexandervalencia commented 5 years ago

Thanks for your work! Sorry it took so long to review and merge.