search

alexanderwallin / node-gettext

A JavaScript implementation of gettext, a localization framework.
Other
188 stars 37 forks source link

Unused code #44

Closed Xesenix closed 4 years ago

Xesenix commented 6 years ago

I have noticed there is some event listener functionality that isn't used. I would expect some event triggered on locale change or not wasting size.

Also this.setLomain doesn't exist anywhere: https://github.com/alexanderwallin/node-gettext/blob/a9c955c1ea2069b487927ca9c9d46a1981641a12/lib/gettext.js#L395

alexanderwallin commented 4 years ago

The listeners are currently for errors!