Error event should emit Error?

alexanderwallin / node-gettext

A JavaScript implementation of gettext, a localization framework.

Other

188 stars 37 forks source link

Error event should emit Error? #50

Closed pronebird closed 4 years ago

pronebird commented 5 years ago

Hi,

It's not the end of the world but it's really strange to see the string emitted as an error from the error handler. Perhaps you meant to wrap it into Error? Doing so also captures the stack trace and helps to figure out where the error comes from.

Cheers, Andrej

alexanderwallin commented 4 years ago

Absolutely! They are errors in v3.0.0.