search

alexanderwallin / react-player-controls

⏯ Dumb and (re)useful React components for media players.
http://alexanderwallin.github.io/react-player-controls/
ISC License
191 stars 35 forks source link

Demo page #1

Closed theideaofnorth2 closed 8 years ago

theideaofnorth2 commented 8 years ago

Hello and thanks for the package!

I've been developing my own audio controls because I couldn't find a package that suits my needs, but yours seems to be modular enough for designers to create what they need, so thanks a lot for exposing this publicly.

One thing that seems to be missing in your project is an examples / demo page, so that people can quickly see if your components are what they need.

Would it be possible for you to display a few examples on a demo page? One simple way to do this could be to use the brand new feature that Github released a few days ago to publish pages with a "docs" directory: https://github.com/blog/2228-simpler-github-pages-publishing

alexanderwallin commented 8 years ago

Hi @theideaofnorth2!

Thanks for the feedback, glad to hear it might fit your needs. A demo page is a good idea, and is already half-done locally. I'll get this going and notify you when it's up!

theideaofnorth2 commented 8 years ago

Great thanks @alexanderwallin , can't wait to see it :)

alexanderwallin commented 8 years ago

So @theideaofnorth2, you can check it out at http://reactify.github.io/react-player-controls/

Any feedback is welcome!

vkammerer commented 8 years ago

Thanks @alexanderwallin (I am also @theideaofnorth2 :) ) it's looking really good! I will integrate at least the volume control and the time marker and let you know if I see bugs or room for improvement.

alexanderwallin commented 8 years ago

Haha, nice. Alright, that sounds perfect!