search

alexanderwallin / react-player-controls

⏯ Dumb and (re)useful React components for media players.
http://alexanderwallin.github.io/react-player-controls/
ISC License
191 stars 35 forks source link

Typescript definitions #49

Open joshferrell opened 5 years ago

joshferrell commented 5 years ago

Would there be any interest in contributions for a typescript migration or creating a new type definition in Definitely Typed?

alexanderwallin commented 5 years ago

Migration: no, type definition: absolutely! 🎉

joshferrell commented 5 years ago

I've created a type definition file that can be used for any react typescript apps that need this. However, I'm not sure what the process for definitely typed is. I can look into that at a later date.

https://gist.github.com/joshferrell/4d6fef5186a8c28db9adf68fff1247c5

alexanderwallin commented 5 years ago

If we include type defs in the repo, does it need to be submitted to DT?

Please make a PR if you wish!