search

alexanderwallin / react-player-controls

⏯ Dumb and (re)useful React components for media players.
http://alexanderwallin.github.io/react-player-controls/
ISC License
191 stars 35 forks source link

Slider not working when component in same file #61

Closed ericqt closed 4 years ago

ericqt commented 4 years ago

If I setup all the slider components in the same file (in app.js) the slider doesn't slide around but if I break out the slider to a separate file and import it in, it will start working.

Does anyone know why this happens? Is there some sort of JS nuance that I'm not aware of?

Code where slider works when broken out to another component: https://gist.github.com/ericqt/f2cbebc8d2ac032364cf32aa86fd7b7e

Code where slider doesn't work within the same file as app.js: https://gist.github.com/ericqt/239d1f111c9f9ddfa876c686b9ea182c

alexanderwallin commented 4 years ago

Hey @ericqt. You are defining components within components in the non-working example. Whenever your sliderValue state changes the components are going to be redefined, and I'm not sure what happens then.

I would recommend using your working example regardless of this issue you are experiencing!