Closed dfangys closed 6 months ago
Hello, thanks for your participation! Can you create a pull request with changes? so i can make review and if it has no issues to merge in master
Hello, thanks for your participation! Can you create a pull request with changes? so i can make review and if it has no issues to merge in master
pull request has been created
Hello, I believe I've resolved an issue in your repository related to the splitting of Unicode SMS messages into 3 parts in the SMPP protocol. Please review the following changes I made:
1- Account for the User Data Header (UDH) when calculating message splits. The UDH for concatenated messages is typically 6 octets (or bytes) in length. 2- Ensure that when calculating the length of a UCS2 encoded message, we account for the fact that each character is represented by 2 octets. Here's the modified code:
in /src/Client.php at sendSMS function
` public function sendSMS( Address $from, Address $to, string $message, array $tags = null, int $dataCoding = Smpp::DATA_CODING_DEFAULT, int $priority = 0x00, $scheduleDeliveryTime = null, $validityPeriod = null ): bool|string { $messageLength = strlen($message);