search

alexandr-mironov / php8-smpp

SMPP Client (v 3.4) on PHP8
7 stars 8 forks source link

Relax loggerinterface requirement #9

Open benrcole opened 1 year ago

benrcole commented 1 year ago

Would it be acceptable to relax the definition of the logging for this library so that any PSR\Logger\LoggerInterface can be used?

I'm using this as part of a wider system and want to use the centralised loggers but the requirement for smpp\LoggerInterface is causing me problems.

If that's acceptable I'll submit a suggestion and a pull request.

alexandr-mironov commented 1 year ago

Hello, yeap, its acceptable, smpp\LoggerInterface is clone of PSR\Logger\LoggerInterface, im understand its not a best solution but has not enough motivation to fix it