search

alexandrainst / alexandra-trackmap-panel

Grafana map plugin to visualise coordinates as markers, hexbin, ant path, or heatmap.
MIT License
77 stars 26 forks source link

Update react-leaflet and dependencies #101

Closed pesintta closed 1 year ago

pesintta commented 1 year ago

Hello. Here is a pretty sizeable contribution to rework the react components of alexandrainst-trackmap-panel.

I've updated react-leaflet from V2 to V3 and removed all deprecated usages such as <Map {ref}> etc. I've also dropped react-leaflet plugins as with V3 onward the internals of leaflet are exposed so that leaflet-plugins can (and should) be used directly. Because react-leaflet plugins are no longer used, some options were modified in the process.

I believe this PR squashes some bugs by the virtue of updating the dependencies but may also introduce new ones, especially if I did not understand some use-case the trackmap-panel plugin can be used for.

My hope is to follow up with further improvements (such as timesyncing support, react-leaflet-V4 etc.) but in order to do that the baseline of the plugin dependencies needs to be brought up to date with this PR (or something similar).

Alkarex commented 1 year ago

Hello and thanks for this welcomed contribution! We do not have internal users or maintainers of this plug-in at the moment, so let me know if you could be interested in getting more rights (either on this repository, or by moving the code to a more public repository).

pesintta commented 1 year ago

Hello and thanks for this welcomed contribution!

We do not have internal users or maintainers of this plug-in at the moment, so let me know if you could be interested in getting more rights (either on this repository, or by moving the code to a more public repository).

In that case I can take more rights in this repository.

I hope we can eventually push a new release to grafana.com and for that this repository would be a good place to continue hosting the code.