Closed eino closed 2 years ago
Hi, Thanks for this nice port!
I found an issue when the target is not found, there is an exception raised (unrelated to stopOnFail, this one crashes the app): Uncaught (in promise) TypeError: e.$emit is not a function
stopOnFail
Uncaught (in promise) TypeError: e.$emit is not a function
I think it's on line 130 of VStep: shouldn't props.$emit( be this.$emit(? https://github.com/alexandreDavid/vue3-tour/blob/4518537c404fa42a6917abe0c09d434df900a1ba/src/components/VStep.vue#L130
props.$emit(
this.$emit(
Edit: I opened PR #4 to fix it
Hi, Thanks for this nice port!
I found an issue when the target is not found, there is an exception raised (unrelated to
stopOnFail
, this one crashes the app):Uncaught (in promise) TypeError: e.$emit is not a function
I think it's on line 130 of VStep: shouldn't
props.$emit(
bethis.$emit(
? https://github.com/alexandreDavid/vue3-tour/blob/4518537c404fa42a6917abe0c09d434df900a1ba/src/components/VStep.vue#L130Edit: I opened PR #4 to fix it