search

alexandrebarachant / muse-lsl

Python script to stream EEG data from the muse 2016 headset
BSD 3-Clause "New" or "Revised" License
616 stars 182 forks source link

fix record_direct crash and respect backend #149

Closed xloem closed 3 years ago

xloem commented 3 years ago

It looks like some past changes left record_direct out, most notably in the order of the arguments, causing a crash. I made these additional fixes during the course of #148 .

This PR also addresses not respecting the user's backend selection for device discovery.

xloem commented 3 years ago

I've merged this PR along with most of the others into https://github.com/xloem/muse-lsl/tree/dev , and resolved bugs on my system, but it still needs somebody else to test it. What would help others have more capacity for pull request maintenance, merging, testing?

jdpigeon commented 3 years ago

Thanks for this, we had been neglecting the record_direct feature and let this slip through.