search

alexandregz / twofactor_gauthenticator

This RoundCube plugin adds the 2-step verification(OTP) to the login proccess
MIT License
221 stars 78 forks source link

The plugin looks bad in classic skin on Roundcube Webmail 1.5.3 #174

Closed takenek closed 2 months ago

takenek commented 1 year ago

Hey, I just install Your plugin and looks verry bad in classic skin on Roundcube Webmail 1.5.3. Take a look: image

Thanks for You work!

Best Regards TaKeN

bvaladon commented 1 year ago

Hello, Same issue with Roundcube 1.61 of Debian Best regards

pikachurus commented 2 months ago

in twofactor_gauthenticator.js, around 150 line: .addClass('listitem twofactor_gauthenticator');

change to: .addClass('tablink twofactor_gauthenticator');

for your own risk

alexandregz commented 2 months ago

thx @pikachurus

takenek commented 2 months ago

less twofactor_gauthenticator.js

// Define Variables
var tabtwofactorgauthenticator = $('<li>')
  .attr('id', 'settingstabplugintwofactor_gauthenticator')
  .addClass('tablink twofactor_gauthenticator');
var button = $('<a>')
  .attr('href', rcmail.env.comm_path + '&_action=plugin.twofactor_gauthenticator')
  .html(rcmail.gettext('twofactor_gauthenticator', 'twofactor_gauthenticator'))
  .attr('role', 'button')
  //.attr('onclick', 'return rcmail.command(\'show\', \'plugin.twofactor_gauthenticator\', this, event)')
  .attr('tabindex', '0')
  .attr('aria-disabled', 'false')
  .appendTo(tabtwofactorgauthenticator);

And still it's broken. Completly northing change for me.