Logout fails on whitelisted session

alexandregz / twofactor_gauthenticator

This RoundCube plugin adds the 2-step verification(OTP) to the login proccess

MIT License

220 stars 77 forks source link

Logout fails on whitelisted session #69

Open bernhy opened 7 years ago

bernhy commented 7 years ago

Hi,

can you please change

if($rcmail->task === 'login') $this->__goingRoundcubeTask('mail');

if($rcmail->task === 'login' && $rcmail->action === 'login') $this->__goingRoundcubeTask('mail');

This will fix the issue.. thanks :)

alexandregz commented 7 years ago

Hi,

I can't reproduce the error. Can you describe used steps to show me, plz?

thx!

bernhy commented 7 years ago

Hi,

I always had the problem with invalid session showing on the logoff screen and this causing a not proper logoff from the system, causing some problems with other plugins. Also I noticed but didnt pay attention, your settings screen didnt work properly, showing passwords in plaintext and so on did not work. But I never tried without a whitelist or from another station but a whitelisted. Well, this fixes both :)

zaharcelac commented 4 years ago

Same thing for me - whenever I have whitelist enabled I get session error on logout.