Closed alexandrehtrb closed 11 months ago
@naitii Please check this requirement.
Hi, I would like to help with this issue (if it is still available) - how should I proceed? Just create my own fork and then create a PR or should I firstly be assigned to this issue. Thanks
Hi,
This issue is available, I can assign it to you if you want!
Yes, fork the repo starting from the develop branch, then open a PR to our repo's develop branch
Thanks, if it is possible to became an asignee then I would like to try it as my first issue.
I have created a PR; I'm not sure if I did it correctly, but I would be glad to hear any form of feedback. Thanks
@tetropolix , what is your opinion?
Connection failed:
Connection success:
Well, if you are asking me if it is readable and intuitive from the perspective of "junior developer" I would say yes. On the other hand I cannot confidently state if it includes all the necessary information for inspection as I do not know all of the inner workings of websocket over http2.
Yes, I was asking about the layout. If it is OK, then I will proceed with this design.
WebSocket over HTTP/2 is pretty much the same as WebSocket over HTTP/1.1, the difference is only at the transport level
I will include this in the next release
Solved with release 2.5.0
Starting at .NET 7, ClientWebSocket can show the connection response status code and headers. This would be a useful information for users and could be presented on the WebSocket connection screen, probably in the middle section, in a Connection response tab.
Should not be hard.
Files to be edited: WebSocketConnectionView.xaml, WebSocketConnectionViewModel.cs, PororocaWebSocketConnector.cs