search

alexandrevicenzi / gistfy

Code once, share everywhere.
MIT License
65 stars 22 forks source link

Update app.js #25

Closed hardcore-newbie closed 8 years ago

hardcore-newbie commented 8 years ago

When i try 'Github repository', i debug by Safari, the bug is 'Can't find variable: $scope' on line 8.

I think just using 'else' is ok.

alexandrevicenzi commented 8 years ago

So, there's 2 PR that does the same thing, and I didn't got what are you trying to fix. Could you explain a little bit?

hardcore-newbie commented 8 years ago

I just change 'else if ($scope.isRepo)' to 'else'

alexandrevicenzi commented 8 years ago

Yep, I think this code is outdated on GitHUb, I'm working on it.

If you're trying to use the master branch I thing you'll have a bad time for now.

alexandrevicenzi commented 8 years ago

@xushvai are you trying to use this version?

hardcore-newbie commented 8 years ago

Yes, i deploy it on my host, you can access http://www.gist-it.xyz

alexandrevicenzi commented 8 years ago

@xushvai are you using the version from NPM? because I forgot to create tags on GitHub, so there's no releases :disappointed:

If not, I would recommend you to use from NPM. The master is a "new" Gistfy. I almost rewrite 75% and it's not ready yet.

hardcore-newbie commented 8 years ago

I just clone the master branch.

alexandrevicenzi commented 8 years ago

If you want, clone the repo again, it's up to date now.

hardcore-newbie commented 8 years ago

ok! Thanks for your project !