search

alexandrialibrary / Alexandria

Alexandria is a simple little card catalogue webapp with a terribly pretentious name.
MIT License
2 stars 1 forks source link

Merge new API spec #53

Closed hawkw closed 9 years ago

hawkw commented 9 years ago
hawkw commented 9 years ago

I'd like @redbassett's approval on this merge request. Obviously, we will eventually want to add auth things to the loans API, but our auth model isn't really worked out yet so I don't know if this is possible.

Also, I'd like to know if @redbassett thinks that this should correspond to a new API spec version number.

codecov-io commented 9 years ago

Current coverage is 69.26%

Merging #53 into master will change coverage by -0.97% by bf1d16a

Coverage Diff

@@            master     #53   diff @@
======================================
  Files            9       9       
  Stmts          309     309       
  Branches         5       5       
  Methods          0       0       
======================================
- Hit            217     214     -3
  Partial          0       0       
- Missed          92      95     +3

Uncovered Suggestions

  1. +11.00% via ...dminController.scala#61...94
  2. +1.94% via .../APIController.scala#169...174
  3. +1.61% via .../AppController.scala#15...19
  4. See 7 more...

Powered by Codecov

redbassett commented 9 years ago

LGTM.

No new version, this is fixing current version, not changing anything. The current 0.0.1-preview is preview because it isn't finalized. It will only be finalized when it works.

hawkw commented 9 years ago

Okay, sounds good. Merging.