search

alexandrnikitin / Topshelf.Unity

Topshelf.Unity provides extensions to construct your service class from your Unity IoC container.
MIT License
7 stars 8 forks source link

Update dependency versions in nuspec #16

Closed Kesmy closed 5 years ago

Kesmy commented 5 years ago

Update the dependency versions in the nuspec to match the project's compile-time dependencies.

Resolves #15

Kesmy commented 5 years ago

@alexandrnikitin The only thing here I did not touch is the readme, which I will leave for you unless you would like it updated.

I updated the version to 4.1.0, but this could maybe be a 4.0.1? I don't think this change would be surprising to consumers, since they would presumably already be using the newer packages with 4.0.0

alexandrnikitin commented 5 years ago

@Kesmy What if downgrade the dependecies to the nuspec lower bounds? Here's a PR for it #18 WDYT?

alexandrnikitin commented 5 years ago

I tested it using the sample project and there are no compiler issue with dependencies.

Kesmy commented 5 years ago

@alexandrnikitin Lowering the dependencies in the other PR is also valid. Since you're OK with a change to support netstandard, this one can be abandoned... Upgrading the packages will happen naturally as part of that support.