alexandrnikitin / Topshelf.Unity

Topshelf.Unity provides extensions to construct your service class from your Unity IoC container.
MIT License
7 stars 8 forks source link

Support for netstandard2.0 #17

Closed Kesmy closed 3 years ago

Kesmy commented 5 years ago

Since both Topshelf and Unity support net452 and netstandard2.0, should Topshelf.Unity also multi-target both?

alexandrnikitin commented 5 years ago

@Kesmy Yes, it would be great! Help appreciated!

Kesmy commented 5 years ago

Note for myself (or if I get hit by a bus...):

This will result in minimum-version upgrades to Topshelf 4.2.1 and Unity.Abstractions 4.1.0, to minimize the number of additional dependencies.

kstrt commented 3 years ago

Hey. Hope you don't mind me taking this one (it has been open a while 😄)

I've just opened PR #19 that should support netstandard2.0 and net452.

alexandrnikitin commented 3 years ago

Closed by #19 @kstrt @Kesmy Thank you for your contribution! Appreciate it.