alexandrtovmach / react-microsoft-login

Microsoft services authorization with React.
https://alexandrtovmach.github.io/react-microsoft-login
MIT License
80 stars 38 forks source link

Children property issue in typescript #102

Closed vigneshRajenthiran closed 1 year ago

vigneshRajenthiran commented 2 years ago

Steps to reproduce:

  1. Installed the latest version of react-microsoft-login
  2. Rendered and tried to add children in the MicrosoftLogin component
  3. Got typescript error " property 'children' does not exist on type 'intrinsicattributes & microsoftloginprops'"

Attachments:

                                                                          <MicrosoftLogin
                                        clientId={office_clientId}
                                        graphScopes={graphScopes}
                                        prompt={'select_account'}
                                        useLocalStorageCache={true}
                                        authCallback={authHandler}
                                        buttonTheme={'dark'}
                                        children={
                                             <Tooltip title={'One Drive'}>
                                                 <IconButton
                                                    onClick={(e:any) => {
                                                        folderClicked = true;
                                                    }}
                                                    color='inherit'
                                                 >
                                                    <Office style={{ height: '20px', width: '20px' }} />
                                                </IconButton>
                                             </Tooltip>
                                        }
                                    />
Malin88 commented 2 years ago

any update on this ?

forge-oscar-caballero commented 1 year ago

No updates at December 16, 2022.

alexandrtovmach commented 1 year ago

I'm planning to start working on next version of this package to use new msal, this issue will be fixed in it

No timeframes I can share

alexandrtovmach commented 1 year ago

Fixed in v2.0.1

https://github.com/alexandrtovmach/react-microsoft-login/commit/851e81ea533b5cf95b733514c6f25c0c683a6f9a