search

alexandrzavalii / focus-trap-js

Trap focus inside specified HTML element. Vanilla JS with size <0.5kb. No external dependencies.
MIT License
16 stars 1 forks source link

Test Coverage on this library #3

Open lychyi opened 4 years ago

lychyi commented 4 years ago

Hi @alexandrzavalii since we're utilizing this library on https://github.com/Workday/canvas-kit/pull/328 can there be a passing suite of tests on the functions of this library?

alexandrzavalii commented 4 years ago

Hi @lychyi, Yeap I am in progress of adding tests. Will start with unit tests first

lychyi commented 4 years ago

@alexandrzavalii any updates on this or a timeline?

alexandrzavalii commented 4 years ago

Hi @lychyi I will try to finish this till the end of this month, I am currently on PTO.

alexandrzavalii commented 4 years ago

@lychyi just created a PR with unit tests https://github.com/alexandrzavalii/focus-trap-js/pull/4/files I am planning to add automation tests as well

lychyi commented 4 years ago

@alexandrzavalii sorry for the delay! thanks for taking a look at this I have it in our sprint project and we'll take a look as soon as possible

NicholasBoll commented 4 years ago

Closed by #4