Closed luisbocanegra closed 1 year ago
A lot of the changes I make require hitting OK to actually reload things, there's probably a better implementation for reloading the plasmoid layout, but I've not figured it out yet. Let's not merge this until we have a better solution for detecting light and dark.
Checking against PlasmaCore.Theme.backgroundColor
is probably what we want to do.
Breeze Dark Breeze I set the indicator specifically to the backgroundColor to demonstrate.
Testing against a bunch of themes, I don't really see an issue with this approach. I'm also not even sure if it is possible to have a plasma style that doesn't have a background color.
Just tested my changes with PlasmaCore.Theme.backgroundColor
and it seems to work fine with the themes I have
If you're happy with the result, then I'm good with merging it.
I think it is good enough in terms of contrast. I feel light themes result in very dark indicators for some applications but is not a bid deal and could work on improve that later in case you merge this as is now :+1:
I'll go ahead and get this merged, thanks! We can definitely revisit making the indicators a little more I guess... light even? But it should be fine for now.
Tints them using background color from color scheme.
Caveats: Requires a Plasma theme that uses backgroundColor from color scheme as panel bg color.
Solutions for that could be:
For some reason indicator color requires closing task to update correctly, not sure if was like this before and this just made it more prominent
before
after