search

alexankitty / FancyTasks

Make your plasma task manager widget pretty.
GNU General Public License v3.0
132 stars 7 forks source link

Putting widget on desktop and dragging it on the bar crashes KDE #7

Closed ziomek64 closed 2 years ago

ziomek64 commented 2 years ago

So, when I put the widget on the desktop and then drag it on the bar it crashes, my whole screen goes black and it restarts KDE i think IDK and when I put it on the left corner of the bar after crash it will be on the right for some damn reason. Again nvidia and X11

alexankitty commented 2 years ago

Alright. I'll look into it. Plasma crashes are difficult to troubleshoot with plasmoids in my experience so hopefully I can find a rhyme or reason for this and that it's not an upstream issue.

ziomek64 commented 2 years ago

@alexankitty It happens only when dragging widget from desktop on bar. Just adding on bar doesn't crash anything though, pretty weird

alexankitty commented 2 years ago

Works fine as a panel but not as a floating widget? Am I understanding that right? If so I might know why.

ziomek64 commented 2 years ago

@alexankitty no both work fine on its own. It is ONLY when dragging it from desktop to a panel

alexankitty commented 2 years ago

I was able to replicate it myself, and it actually crashed both ways.

ziomek64 commented 2 years ago

@alexankitty I haven't actually checked moving it from panel to floating state lol. But yeah, as you can see the issue exists.

alexankitty commented 2 years ago

Alright, the good thing is it can be easily reproduced. I'll see what I can do about fixing it.

alexankitty commented 2 years ago

This crash is caused by the state switching that controls indicator positions. I'll work on a fix for this.

alexankitty commented 2 years ago

Looking into this further I made a mistake. The state switching is still at least important for the floating dock but it actually seems the crashing stems from putting the computer to sleep and waking it and then moving it. I made this realization when I was doing testing and forgot to replace the plasmoid and thought commenting out my states fixed it, but instead the crashing wasn't reproduceable until I made my computer sleep.

alexankitty commented 2 years ago

Actually, I'm not sure anymore. maybe I got a bit flip or something I can't reproduce again. I've pushed the commit to the bug-fixing branch here https://github.com/alexankitty/FancyTasks/tree/bug-fixing I'll include an update script to allow you to update after cloning the repo so you can test and let me know if it's working on your end before I merge.

alexankitty commented 2 years ago

Additional update for a default case for the indicators if the override isn't selected.