search

alexarchambault / mill-native-image

Apache License 2.0
18 stars 6 forks source link

Mill dependencies should be defined as `compileIvyDeps` #69

Closed lefou closed 10 months ago

lefou commented 10 months ago

While analyzing an reported issue to Mill which only occurs in a project using this plugin, I recognized, that API dependencies to Mill (and it's dependencies like os-lib) are defined as ivyDeps, whereas they are supposed to be defined via compileIvyDeps. This is because the correct runtime version is provided by Mill when the plugin is loaded into Mill's classpath and should not be included in the transitive dependency set.

carlosedp commented 10 months ago

If there are no drawbacks on this, I can send a fixing PR.

carlosedp commented 10 months ago

I think this might do it... https://github.com/alexarchambault/mill-native-image/pull/70

carlosedp commented 10 months ago

Publishing is failing... I've pinged Alex to help out since it looks like something related to the gpg key...

lefou commented 10 months ago