alexarchambault / plotly-scala

Scala bindings for plotly.js
http://plotly-scala.org
220 stars 47 forks source link

Add new properties for Histogram and layout.Axis #432

Closed sven42 closed 1 month ago

sven42 commented 2 months ago

This fixes #431.

Furthermore:

Best regards, Sven

sbrunk commented 1 month ago

Looks good to me.

@alexarchambault are you ok with me merging this and cutting a v0.8.5 release afterwards? The release should work automated from CI after tagging with sbt-ci-release right? I haven't done it yet in this repo though so I want to check with you first.

alexarchambault commented 1 month ago

@sbrunk Sure, go ahead. Feel free to review / merge things as you feel in this repo.

sbrunk commented 1 month ago

Uh, seems like there's some issue with publishing due to a missing pgp key: https://github.com/alexarchambault/plotly-scala/actions/runs/9061691273/job/24894080970 Perhaps you have to trigger the publishing job @alexarchambault?

alexarchambault commented 1 month ago

@sbrunk I just updated the secrets, that seems to have fixed it

sbrunk commented 1 month ago

Thanks @alexarchambault!