search

alexbatalov / fallout1-ce

Fallout for modern operating systems
Other
2.18k stars 150 forks source link

use uppercase music file in main menu #128

Open hughobrien opened 9 months ago

hughobrien commented 9 months ago

As per the docs:

Music files themselves (with ACM extension) should be all uppercased, regardless of sound and music folders.

Running under strace shows ENOENT due to hardcoded lower-case

strace -e trace=open,openat fallout-ce

openat(AT_FDCWD, "data/sound/music/07desert.ACM", O_RDONLY) = -1 ENOENT (No such file or directory)
avnik commented 5 months ago

@hughobrien may be better use compat_resolve_path in code playing music, instead change hardcoded casing?

hughobrien commented 5 months ago

Agreed in principle, but that would likely be a refactor more than a bug fix. e.g. this pattern is used elsewhere in the file:

https://github.com/alexbatalov/fallout1-ce/blob/ad8a2754fa99ceaf40495185ad48191cf27559e2/src/game/worldmap.cc#L1145

hughobrien commented 5 months ago

@alexbatalov May I ask if this is a change you would consider merging or if you would prefer an alternative approach? Thank you for your work.