search

alexbatalov / fallout1-ce

Fallout for modern operating systems
Other
2.1k stars 146 forks source link

Patched snprintf() calls to provide required format specifiers #185

Open dje4321 opened 2 months ago

dje4321 commented 2 months ago

Unable to compile on linux due to missing format specifiers per the CPP reference. https://cplusplus.com/reference/cstdio/snprintf

PR patches snprintf() calls to provide the required format specifiers.

dje4321 commented 2 months ago

Important thing to note. Not all snprintf() calls were checked. Only patched those that were preventing compilation.

There are some potential security implications by not passing in the required format specifier, however since this is a premade application with no real user inputs, none of those implications are particularly relevant.