alexbatalov / fallout1-ce

Fallout for modern operating systems
Other
2.18k stars 150 forks source link

movie_lib.cc: Fix incorrect return type of `getOffset` #195

Open glebm opened 3 months ago

glebm commented 3 months ago

The type was changed from auto to uint8_t when merging #117, but the correct return type is actually int.

Fixes #136 Fixes #194

There is an alternative fix in #188 (with a graph of generated values) but I think the return type there (int16_t) is incorrect.

/cc @alexbatalov @Zenkibou @hippydave @KulikAlex @dje4321

glebm commented 3 months ago

@alexbatalov Can you please merge this? The bug was introduced in your changes to my PR #117 when you were merging it.