No music since v1.2 - Githubissues

Vic2077 commented 1 year ago

Since v1.2 music is not playing anymore (plays fine in older builds). Same for Fallout1-ce (v1.0 doesn't play backgroun music). Main menu and videos have music, everything else (like background noises like dog barks in Arroyo) is working, but the location music doesn't play.

APAmk2 commented 1 year ago

There is some reports about that, but strange, in F2, F:N and F:S sound is fine, everything plays fine

Vic2077 commented 1 year ago

Hmm, maybe I should check Sonora and Nevada too. But then again, the only thing that changed is the apk file. Game files are the same, and with older apks music still plays fine with the same game files.

QcSamuel commented 1 year ago

tried the solution on fallout1-ce repo for ios and music is still not playing

Vic2077 commented 1 year ago

tried the solution on fallout1-ce repo for ios and music is still not playing

Also tried to rename all files and folders and lines in the cfg file to CAPITALS - no result. (although I've tried this on fallout1-ce, but in Fallout 2 it all already is in lowercase letters and music still doesn't play.)

bencarr1337 commented 1 year ago

Tried renaming all the files in fallout2.cfg but still no music for me either

bencarr1337 commented 1 year ago

Hello All, i have found the issue i was having. In the "data/sounds/music" folder, all of the music files were lower case, if you change them to upper case it works fine.

APAmk2 commented 1 year ago

That is not reason of problem, this is too stupid thing that need to test as firstly as can, we are tried that already, nothing changed

Vic2077 commented 1 year ago

works fine

not for me

bencarr1337 commented 1 year ago

Yeah, it only worked for me on the trials level. The world map, Klamath etc it still doesn’t work for me.

would really like a resolution for this as it kills the atmosphere.

alexbatalov commented 1 year ago

I've checked last debug version, music works as expected (checked main menu, arroyo, temple of trails, den). If it doesn't work, please post screenshots from Files app showing your folder hierarchy (data/sound/music) and contents of your fallout2.cfg.

alexbatalov commented 1 year ago

Any additional info on this one?

bencarr1337 commented 1 year ago

Any additional info on this one?

I extracted the file that contains the references to the music files (I forget what it’s called now) and it looks like the filenames it refers to are a mix of uppercase and lowercase so some places work and some don’t depending on your config file. Obviously this doesn’t make a difference on windows but on nix OS’s it does.

psemiletov commented 1 year ago

У меня то же самое - Arch Linux, сам звук есть, музыки нет. В конфиге: music_path1=data/sound/music/ music_path2=data/sound/music/ Содержимое каталогов пытался и в нижнем регистре, и в верхнем - нет музыки. Файлы F2 взяты из версии от GOG.

alexbatalov commented 1 year ago

Check if #214 helps (https://github.com/alexbatalov/fallout2-ce/actions/runs/4670923559).

psemiletov commented 1 year ago

Sorry but still no music. I've tested some locations - the world map, NCR, Vault 15. I can compile from the source, is there some hints where to check something in the code?

alexbatalov commented 1 year ago

That's strange. Can you check v1.1 without changing anything in the config/directory layout so we can be sure it's something in the code?

lexurco commented 1 year ago

I did some of my own testing on the issue both in the tagged (v1.2.0) and current-commit (c8d4585) versions:

Without my patch, or file renaming, there indeed appears to be no music.
Interestingly, fallout2-ce now appears to sometimes attempt to load empty-string ("\0") filenames, which I found out after applying my own patch. That definitely didn't use to happen.
After I added an additional check at the end of compat_windows_path_to_native() (i.e. put an "if (d)" before "closedir(d)"), the game launched, and there was music at the main menu (which I remember being the first problem with music I ever noticed before making the patch), but attempting to start a new game, or loading a saved game leads to segfault.

So, I think most likely some bad filenames are being supplied to compat_windows_path_to_native(), and presumably somewhere else later.

psemiletov commented 1 year ago

That's strange. Can you check v1.1 without changing anything in the config/directory layout so we can be sure it's something in the code?

Things goes more strange... I have two Linux GOG F2 directories with identical files (including f2_res.ini, ddraw.ini, fallout2.cfg). At one of them I hear music, at another one there are no music. I've tried make diffs - files are the same. I've tried copy files one by one to see when there will be no music at the "normal" F2 copy. No result. It seems config files are not related to that.

alexbatalov commented 1 year ago

Let's even things:

Download latest debug build of the main branch (https://github.com/alexbatalov/fallout2-ce/actions/runs/4670076031).
Grab HQ music (https://github.com/BGforgeNet/Fallout2-HQ-music/releases/tag/v8)
In your Fallout 2 directory (that's where fallout2.cfg is) create sound/music/ (lowercased), unpack HQ music into this folder.
Uppercase all acm files (i.e. music in main menu 07DESERT.ACM).
Delete fallout2.cfg (defaults are fine for this setup).

Post your results.

QcSamuel commented 1 year ago

Let's even things:

Download latest debug build of the main branch (https://github.com/alexbatalov/fallout2-ce/actions/runs/4670076031).

Grab HQ music (https://github.com/BGforgeNet/Fallout2-HQ-music/releases/tag/v8)

In your Fallout 2 directory (that's where fallout2.cfg is) create sound/music/ (lowercased), unpack HQ music into this folder.

Uppercase all acm files (i.e. music in main menu 07DESERT.ACM).

Delete fallout2.cfg (defaults are fine for this setup).

Post your results. tried it on ios and the main menu music play for 2 second before stopping and no music in game

alexbatalov commented 1 year ago

@Vic2077 @QcSamuel Guys can you check it one more time with the latest debug build?

QcSamuel commented 1 year ago

@alexbatalov tried the latest debug it works now for me on ios

007hacky007 commented 11 months ago

@alexbatalov I can confirm music works just fine in 1.1 release and does work only for few seconds on 1.2 release (macOS build). Same behavior with HQ music as well as default music files included in the GOG's release. All tests with music files renamed to uppercase.

I'm unable to test latest build, because last week's artifacts already expired.

alexbatalov commented 11 months ago

That's odd, last time I played on a Mac music was there. Will check and get back with result in a couple of days.

alexbatalov commented 11 months ago

I've tried v1.2 from releases as well as building from source both debug and release configurations, music works on Intel Mac. Post your fallout2.cfg and make a screenshot of your directory layout (tree view, be sure to reveal acm files). I'll try to replicate that one to one to see what's going on. Thanks.

007hacky007 commented 11 months ago

I've got Apple Silicon - M1 Pro to be exact. I'm running macOS Ventura 13.6.

My fallout2.cfg is completely default. I've even deleted the file and let it to be recreated with default values as you suggested in one of your previous replies. Anyway I'm attaching both tree output and fallout2.cfg file.

Note: sound/music2 directory is the original .acm music files that came with GOG release (just renamed to uppercase) and sound/music is the HQ music renamed to uppercase.

With 1.2 release the music works for few seconds and then it stops. And just with replacing the .app with 1.1 release, it starts working (without any additional steps - i.e. changing the fallout2.cfg.

treeFallout2.txt fallout2.cfg.txt

alexbatalov commented 11 months ago

Can you please check latest debug build just to make it has not been already fixed.

007hacky007 commented 11 months ago

I can confirm that music works just fine with the latest debug build.

rumly111 commented 6 months ago

for me, I had to rename the files to blah.ACM to make it work , so only the extension is uppercase. I'm on version 1.2.0

    for a in * ; do mv $a `basename $a .acm`.ACM -v ; done

ArminiusTux commented 5 months ago

Greetings, I must also confirm that this is still an issue with the latest code base (compiled 31afb4d for WinARM64).

Quick fix for Windows:

cmd
cd \fallout2-folder\sound\music
ren *.acm *.ACM

alexbatalov commented 5 months ago

@ArminiusTux Hey, can you please check the latest debug build? You've said you are on WinARM64, is your file system case-sensitive?

ArminiusTux commented 5 months ago

Dear @alexbatalov , Windows on ARM is as any other Windows variant case-insensitive (i.e. README.TXT can not coexist with readme.txt in the same folder). Although you can apparently change that now on a folder by folder case.

As for your latest build linked above, the file downloads seem to have expired:

alexbatalov commented 5 months ago

Please check this one: https://github.com/alexbatalov/fallout2-ce/actions/runs/8581579710

ArminiusTux commented 5 months ago

Your latest x64 build (SHA256=05FB8E9097AE8CE0667690BF8665120F9F9AEA9123699F4F8E46615FD5228EDA) is fine, tested the fallout2-ce.exe on Win10 x64 & Win11 ARM64.

Oddly I am not able to reproduce the original problem (loaded several save games & renamed the music files back & forth). From my side you can close this issue now.

tonurics commented 4 months ago

I was also able to get music working on Linux:

Download the HQ Music: https://github.com/BGforgeNet/Fallout2-HQ-music/releases/tag/v8
Extract into: ./sound/music/ (move or remove old music files)
Change the file extensions to upper case: rename '.acm' '.ACM' *

I'm guessing the important bit is the file extension case. But included all steps to allow someone else to reproduce my results.

alexbatalov commented 4 months ago

Resolved in v1.3

alexbatalov / fallout2-ce

No music since v1.2 #251