search

alexbeletsky / elmah-mvc

Painless integration of ELMAH into ASP.NET MVC application
http://nuget.org/packages/Elmah.MVC
Apache License 2.0
266 stars 61 forks source link

Adding authentification by UserName #33

Closed pehadavid closed 11 years ago

alexbeletsky commented 11 years ago

Very near code!

alexbeletsky commented 11 years ago

Nice I meant ;)

pehadavid commented 11 years ago

very usefull for us, because we don't use roles :)

alexbeletsky commented 11 years ago

Will add it asap ;)

pehadavid commented 11 years ago

Thank you !

alexbeletsky commented 11 years ago

Will verify code and push to NuGet soon (bit slow to me, since I'm currently not on Windows env.)

Thanks again for great asset!

alexbeletsky commented 11 years ago

http://nuget.org/packages/Elmah.MVC/ pushed to nuget repo. Please try to update and check if it works as expected. :)

pehadavid commented 11 years ago

that's ok for me, but there is something tricky : if I want to use authentification by username, i have to remove * from elmah.mvc.allowedRoles and put something else instead. I'll send you a fix ASAP ;)

Note : this behavior can be acceptable, so let me know if you don't want a fix

alexbeletsky commented 11 years ago

@papci that could be unexpected, so please prepare a fix for it :) thanks a lot!