search

alexbeletsky / elmah-mvc

Painless integration of ELMAH into ASP.NET MVC application
http://nuget.org/packages/Elmah.MVC
Apache License 2.0
266 stars 61 forks source link

Added null check for Elmah http handler. #38

Closed bennor closed 10 years ago

bennor commented 10 years ago

When any registered instance of Elmah's IRequestAuthorizationHandler interface fails authorization or Elmah is not configured to allow remote access, it will set the status code to 403 and return null.

Calling ProcessRequest on a null handler causes a NullReferenceException which is logged and emailed.

alexbeletsky commented 10 years ago

Thanks @bennor - I would like to merge it in and push the fix. The problem, I don't do any .NET development now and have no access to Windows box.

Would like to help a project and became maintaner, so you be able to update NuGet package?

bennor commented 10 years ago

Yeah mate, I'd be more than happy to. Just let me know what I need to do.

alexbeletsky commented 10 years ago

Sounds cool! Please, first of all, register on NuGet and install it on your machine (I assume, it's already there, you can check nuget.exe from comand line). Just let me know your NuGet account name I'll try to add you as maintaner.

As soon as we are there, I'll send you further instructions :)