search

alexbeletsky / elmah-mvc

Painless integration of ELMAH into ASP.NET MVC application
http://nuget.org/packages/Elmah.MVC
Apache License 2.0
266 stars 61 forks source link

Changing authorize attribute to support roles or usernames #41

Closed vondruska closed 10 years ago

vondruska commented 10 years ago

This allows the implementer to permit a role without needing to have an explicit list of usernames accompanying the role.

alexbeletsky commented 10 years ago

thanks @vondruska!

I'm just wondering, this functionality is supposed to work then you have user user and role *, why wouldn't that work for you?

vondruska commented 10 years ago

You make a valid point, and upon more inspection that does work. But that seems really confusing to me. I saw it as "allow all users and allow users in role 'Admin'" which really wouldn't help anything since all users were allowed. Not "allow all users in the role Administrator".

I was putting a blank value into the allowedUsers field, and putting my allowed roles in the allowedRoles field, which caused this confusion and thus pull request.

alexbeletsky commented 10 years ago

great it's clear at the very end :)