alexbeletsky / elmah-mvc

Painless integration of ELMAH into ASP.NET MVC application
http://nuget.org/packages/Elmah.MVC
Apache License 2.0
266 stars 61 forks source link

HandleError attribute #7

Closed nogginbox closed 12 years ago

nogginbox commented 12 years ago

When I moved accross to using Elmah.MVC I thought I could remove my custom error handler code that I implemented based on this question:

http://stackoverflow.com/questions/766610/how-to-get-elmah-to-work-with-asp-net-mvc-handleerror-attribute

My custom error handler means I can show users a nice error message and still log elmah errors. Removing it though meant the errors were no longer logged.

Does elmah.mvc deal with this issue in a different way and I've not configured it right, or is it out of the scope of this very excellent module.

alexbeletsky commented 12 years ago

Unfortunately you have to have use HandleError as in stackoverflow article describe, you can just remove it. What ELMAH.MVC is provide - only the controller in "Admin" area that you can access ELMAH pages in nice MVC way.

So, now its out of scope :(

But, your question is very interesting and I will think about that. Will keep that issue opened.

nogginbox commented 12 years ago

Thanks for replying so quickly, and thanks for this project. Thought it might be out of scope, but a built in solution to the problem would be really neat.

alexbeletsky commented 12 years ago

Welcome :)

I'm happy to hear new suggestions :).. Hope it's really possible!

alexbeletsky commented 12 years ago

Will be supported in 2.0. version

nogginbox commented 12 years ago

Excellent!!!

alexbeletsky commented 12 years ago

Implemented, can be closed