Possible Enhancements - Githubissues

vikeen commented 9 years ago

Before continuing before I want to say this was far and away the best notification module I found during my research. Given that I needed to modify it quite substantially I wanted to also praise the code quality because it took barely any time to grasp everything.

Unfortunately, I did run into issues and I would like to share my cases for possible enhancements to the main code base.

Use $cookieStore to save prevent notifications a user has already dismissed / closed
- This has a config spot in the provider (getSaveResponse, setSaveResponse)
- Add a provider config option for the cookies prefix value
- validate that a notification with saveResponse also has a id parameter. This was needed to find correspond correct notifications for dismissal.
Give the ability to modify the template or provide a custom one through either transclude or template-url attribute.
Decouple glyphicons. Fairly straight forward. I was using font awesome and needed to change the template because of this. The close icon doesn't need to be library specific. Maybe add a way to customize it?
Add a notification class to each notification div in the template along with the note.type.
- This is a minor one because I just wanted to use a selector like .notification to target each entire notification. I could have used a child selector, but it just seemed like overkill for a html element that was a notification.

Let me know what your thoughts are. The template things are fairly opinionated for myself, but I do believe they are all good features.

alexbeletsky commented 9 years ago

@vikeen that's just amazing feedback. I like each of propositions you have and would like to implement it for 0.1.0 version.

I've created tickets for each of propositions, this one is about to be closed. Let's move the discussion and actual PR's there.

calling @dmaslov, @tommaitland, @jguffey - your help is needed, please join here.

vikeen commented 9 years ago

Awesome! I'm glad I could help provide some feedback.

tommaitland commented 9 years ago

Happy to pick up some of these, I made similar changes to my implementation of it. I'm away until March but I'll have a look at what's remaining then.

On Sat, Feb 7, 2015 at 12:03 AM, John Rake notifications@github.com wrote:

Awesome! I'm glad I could help provide some feedback.

Reply to this email directly or view it on GitHub: https://github.com/alexbeletsky/ng-notifications-bar/issues/15#issuecomment-73271910

alexbeletsky / ng-notifications-bar

Possible Enhancements #15

Awesome! I'm glad I could help provide some feedback.