search

alexbeletsky / ng-notifications-bar

Angular.js component for stylish and flexible top bar notifications.
http://beletsky.net/ng-notifications-bar
149 stars 52 forks source link

Check this please #49

Open SaulBurgos opened 8 years ago

SaulBurgos commented 8 years ago

I have fixed a problem with the remove of notificators

alexbeletsky commented 8 years ago

@SaulBurgos thanks a lot! Very likely the root cause is in this line. It's actually quite bad implementation there.

Instead of id it's possible to use a return value of push(), since it gives a new length of array, correspondingly index of notification is newLenght - 1 is an index of inserted notification. Then, it could be simply removed by index, not by id.

Would you like to take care of that?

GaryTowers commented 7 years ago

Hi guys, are there any plans to merge this PR to fix this issue soon?

lciolecki commented 7 years ago

@alexbeletsky are you plan to merge this PR?

davewood commented 5 years ago

bump?