alexbeletsky / ng-notifications-bar

Angular.js component for stylish and flexible top bar notifications.
http://beletsky.net/ng-notifications-bar
149 stars 52 forks source link

added ability to control the delay before hiding. Added missed dependency to package.json #7

Closed dmaslov closed 9 years ago

dmaslov commented 9 years ago

Hey, @alexanderbeletsky ! I think that wouldn't be excess to have ability to manually control the delay before hiding. So if you don't mind, please, merge my pull request with that feature implementation. Also i added grunt-contrib-connect to dependencies in package.json (grunt start:example from your readme doesn't work without that dependency)

alexbeletsky commented 9 years ago

hey @dmaslov - this looks great!

I would add some minor detail here. It would be great, if hideDelay could be also specified in configuration time of directive.

app.config(['notificationConfigProvider'], function (notificationConfigProvider) {
   notificationConfigProvider.setHideDelay(1500);
}]);

If you make this happen, that would be awesome :)

dmaslov commented 9 years ago

@alexanderbeletsky! added global control of hideDelay option through module configuration. If i did something that you don't expected, please let me know. I'll fix that :)

alexbeletsky commented 9 years ago

hey @dmaslov - everything looks awesome :) I've noticed some formatting issues, if you are able to fix it, it will be great.

To make PR complete, I would like to ask you following:

  1. Rebase it on current master (I've applied some changes yesterday, but you should not have conflicts potentially).
  2. Extend README.md with information about new config option.

Please conclude it, I'll be happy to put that in. Thanks a lot for your help :)

dmaslov commented 9 years ago

@alexanderbeletsky! Done

alexbeletsky commented 9 years ago

version 0.0.4 just published :)

dmaslov commented 9 years ago

awesome! :)