alexbelgium / hassio-addons

My homeassistant addons
MIT License
1.36k stars 193 forks source link

✨ [REQUEST] Baikal to use addon_configs repo #1354

Closed JeffersonBledsoe closed 1 month ago

JeffersonBledsoe commented 2 months ago

Checked

Which addon?

Baikal

Is your feature request related to a problem? Please describe

Baikal currently uses the /config/addons_config directory. Some of your other addons have already been udated to use the /addons_config directory, but this feature is missing from Baikal. Additionally, the addon doesn't start without creating a config.yaml file with a variable in it.

Describe the solution you'd like

Move to using the Home Assistant addons config

alexbelgium commented 2 months ago

Hi, thanks! What is the content of /config/addons_config/baikal ?

JeffersonBledsoe commented 2 months ago

It defaults to the env injector template:

#============================#
# ALEXBELGIUM'S ENV INJECTOR #
#============================#
#
# All env variables set in this file will be enabled in the app
# This allows enabling more options that normally available in the addon options
# This file must be filled according to the yaml format.
# If the format is invalid, the addon will note an error.
# To validate your yaml, you can use the free online tool http://www.yamllint.com/
# You can use env both for the addon, and for bashio. For bashio, use BASHIO_LOG_LEVEL instead of LOG_LEVEL

# EXAMPLE of the format (you need to remove the # for it to become active)
#TZ: Europe/Paris

However like this it fails to start as it doesn't find any env variables to set. Uncommenting the TZ fixes the startup

alexbelgium commented 2 months ago

Thanks! I'll push a new version this afternoon with the addon_config folder and we'll see if it makes a difference

JeffersonBledsoe commented 1 month ago

@alexbelgium Seems to work well from the new location, thanks! I also tested doing a fresh install and it now starts up without having to manually create the file, nice work!