search

alexbelgium / hassio-addons

My homeassistant addons
MIT License
1.49k stars 213 forks source link

🐛 [Mealie] Mealie pulling Nightly, not the latest release version #1548

Closed andrew-codechimp closed 1 month ago

andrew-codechimp commented 1 month ago

Description

The latest Mealie update has pulled the Nightly rather than V1.12.0 https://github.com/alexbelgium/hassio-addons/commit/a63794a23b268464a187b83eb543f58ec07f98ea

This addon has been doing nightlies for a while, but the latest nightly is the V2 beta which has major breaking changes, is not fully tested. The official Mealie integration for HA has not yet been updated to support this so will break, along with existing rest based implementations. I'm not sure if this can be reverted as there are DB changes but can the build for this be fixed to pick up the latest prod release rather than the nightly to avoid this scenario in future?

Reproduction steps

Install latest add-on
Look at the version within the Mealie web UI which says Nightly, not V1.12.0

Addon Logs

No errors in logs.

Architecture

amd64

OS

HAos

alexbelgium commented 1 month ago

Thanks, I'll revert to latest tag but then likely all current installations will break down or become corrupted

andrew-codechimp commented 1 month ago

Thanks for quickly changing this, yes it's not ideal for those that have updated already but at least it will stop the majority having issues.

alexbelgium commented 1 month ago

Thanks for having raised it, I've added a comment in the changelog hopefully it will help

alexbelgium commented 1 month ago

Hi, looks like database is stored in a separate container and not mealie's. This means that people likely won't have backups. I fear that now that people's database have moved to v2 we will be stuck with it...

andrew-codechimp commented 1 month ago

Mealie has its own backup system for its data, which you have to download and store it somewhere, but unless you have a working Mealie instance you won't be able to get back in to restore it. The nightly builds could break things at any time so latest is the way to go forwards but if we revert to nightly now then approx 1500 users of the Mealie integration will have that breaking until at least the next HA release.

alexbelgium commented 1 month ago

Indeed this is quite inconvenient, as the users of the addon will likely have anyway to reset their databases if they don't have performed such a backup. I will describe a manual way to restore the backup but it is something needing to go into the system files and could be complex for this number of users

There was 1030 unique downloads of the mealie addon since last update so this should reflect at +/-20% the amount of users impacted

tonka3000 commented 2 weeks ago

@alexbelgium Does that mean that I can not fix it if I have no backup from weeks ago? Or is it enough to create a mealie backup now (from the 2.0 version in 1.12.0) and restore it in the old version (1.2 in 1.12.0-2).