alexbelgium / hassio-addons

My homeassistant addons
MIT License
1.5k stars 214 forks source link

🐛 [Qbittorrent] New build ignores config/save path #470

Closed deku-m closed 2 years ago

deku-m commented 2 years ago

Which addon?

Describe the bug

Looks like the new build is creatign a new path and ignores old config/save path. To Reproduce

Full addon log

Full addon config

System

deku-m commented 2 years ago

TO add now it is moving all torrents/files to share where add-on is running and not the mountpath in configuration yaml. So my storage was full.

alexbelgium commented 2 years ago

Thanks, I'll look at that ASAP

alexbelgium commented 2 years ago

That's indeed due to the new way of working of the upstream image. I'll try to solve this ASAP

alexbelgium commented 2 years ago

Apologies to everyone, this is now solved and tested working in version 4.4.5-r0-ls214-2

txitxo0 commented 2 years ago

From the bug I can't get my addon working again :S

In the log I see something about a problem with s6-rc.

Could you take a look at help me, please?

[custom-init] no custom services found, skipping...
[migrations] started
[migrations] no migrations found
cont-init: info: running /etc/cont-init.d/00-aaa_dockerfile_backup.sh
Executing modules script : 00-banner.sh 92-local_mounts.sh 92-smb_mounts.sh 90-dns_set.sh
/etc/cont-init.d/00-aaa_dockerfile_backup.sh: line 15: apt-get: command not found
exec: fatal: unable to exec bashio: No such file or directory
s6-rc: warning: unable to start service init-adduser: command exited 127
00-banner.sh
92-local_mounts.sh
92-smb_mounts.sh
90-dns_set.sh
Executing dependency script with custom elements : 
-----------------------------------------------------------
 Add-on: Qbittorrent
 qBittorrent is a bittorrent client
-----------------------------------------------------------
 Add-on version: 4.4.5-r0-ls214-2-bugfix
 You are running the latest version of this add-on.
 System: Raspbian GNU/Linux 10 (buster)  (armv7 / raspberrypi4)
 Home Assistant Core: 2022.9.1
 Home Assistant Supervisor: 2022.08.6
-----------------------------------------------------------
 Please, share the above information when looking for help
 or support in, e.g., GitHub, forums
 https://github.com/alexbelgium/hassio-addons
-----------------------------------------------------------
[08:09:37] INFO: DNS SERVERS set to 1.1.1.1 8.8.8.8 
90-dns_set.sh : executing
92-smb_mounts.sh : executing
92-local_mounts.sh : executing
00-banner.sh : executing
cont-init: info: /etc/cont-init.d/00-aaa_dockerfile_backup.sh exited 0
cont-init: info: running /etc/cont-init.d/00-folders.sh
cont-init: info: /etc/cont-init.d/00-folders.sh exited 0
cont-init: info: running /etc/cont-init.d/30-nginx.sh
cont-init: info: /etc/cont-init.d/30-nginx.sh exited 0
cont-init: info: running /etc/cont-init.d/91-qbittorrent_configuration.sh
[08:09:43] INFO: Downloads can be found in share/usb/qBittorrent
[08:09:43] INFO: Whitelisted subsets will not require a password : localhost,127.0.0.1,172.30.0.0/16,192.168.0.0/16
[08:09:44] INFO: WEBUI username set to pi
[08:09:44] INFO: Alternate UI enabled : vuetorrent. If webui don't work, disable this option
[08:09:46] INFO: Default username/password : admin/adminadmin
[08:09:46] INFO: Configuration can be found in /config/addons_config/qBittorrent
cont-init: info: /etc/cont-init.d/91-qbittorrent_configuration.sh exited 0
cont-init: info: running /etc/cont-init.d/93-openvpn.sh
[08:09:47] INFO: Direct connection without VPN enabled
cont-init: info: /etc/cont-init.d/93-openvpn.sh exited 0
/run/s6/basedir/scripts/rc.init: warning: s6-rc failed to properly bring all the services up! Check your logs (in /run/uncaught-logs/current if you have in-container logging) for more information.
prog: fatal: stopping the container.
alexbelgium commented 2 years ago

Hi, argh I can't replicate ; for me it starts fine and without issues. I suppose you are on supervised on not HA os ?

txitxo0 commented 2 years ago

Yep, it is a supervised (dockerize) installation on my pi 4.

Mmmm, how can I help you to realize about the error?

alexbelgium commented 2 years ago

It's ok, I see the issue. Previously, my custom code was executed prior to the upstream code, now it is parallel. This induces issues only on supervised installations. I'll hijack their code to force mine being executed first.

alexbelgium commented 2 years ago

Could you please test this version 4.4.5-r0-ls214-2-bugfix2? Thanks

txitxo0 commented 2 years ago

Mmm I can't update

The command '/bin/sh -c if ! command -v bash >/dev/null 2>/dev/null; then (apt-get update && apt-get install -yqq --no-install-recommends bash || apk add --no-cache bash) >/dev/null; fi && if ! command -v curl >/dev/null 2>/dev/null; then (apt-get update && apt-get install -yqq --no-install-recommends curl || apk add --no-cache curl) >/dev/null; fi && curl -f -L -s -S "https://raw.githubusercontent.com/alexbelgium/hassio-addons/master/.templates/automatic_packages.sh" --output /automatic_packages.sh && chmod 777 /automatic_packages.sh && eval /./automatic_packages.sh "${PACKAGES:-}" && rm /automatic_packages.sh || (printf '%s\n' "${PACKAGES:-}" > /ENVFILE; if [ -f /etc/s6-overlay/s6-rc.d/init-migrations/run ]; then chmod /etc/cont-init.d/00-aaa_dockerfile_backup.sh && sed -i "1a /./etc/cont-init.d/00-aaa_dockerfile_backup.sh" /etc/s6-overlay/s6-rc.d/init-migrations/run;fi)' returned a non-zero code: 1
alexbelgium commented 2 years ago

Could you please post the full log? The error messages should be below. Thanks!

txitxo0 commented 2 years ago

I can't show much more than this...

The command '/bin/sh -c if ! command -v bash >/dev/null 2>/dev/null; then (apt-get update && apt-get install -yqq --no-install-recommends bash || apk add --no-cache bash) >/dev/null; fi && if ! command -v curl >/dev/null 2>/dev/null; then (apt-get update && apt-get install -yqq --no-install-recommends curl || apk add --no-cache curl) >/dev/null; fi && curl -f -L -s -S "https://raw.githubusercontent.com/alexbelgium/hassio-addons/master/.templates/automatic_packages.sh" --output /automatic_packages.sh && chmod 777 /automatic_packages.sh && eval /./automatic_packages.sh "${PACKAGES:-}" && rm /automatic_packages.sh || (printf '%s\n' "${PACKAGES:-}" > /ENVFILE; if [ -f /etc/s6-overlay/s6-rc.d/init-migrations/run ]; then chmod /etc/cont-init.d/00-aaa_dockerfile_backup.sh && sed -i "1a /./etc/cont-init.d/00-aaa_dockerfile_backup.sh" /etc/s6-overlay/s6-rc.d/init-migrations/run;fi)' returned a non-zero code: 1
Config folder moved to /config/addons_config/qBittorrent
4.4.5-r0-ls214 (09-09-2022)
Update to latest version from linuxserver/docker-qbittorrent
4.4.5-r0-ls213 (01-09-2022)
Update to latest version from linuxserver/docker-qbittorrent
4.4.3.1-r1-ls211 (30-08-2022)
Update to latest version from linuxserver/docker-qbittorrent
4.4.3.1-r1-ls210 (13-08-2022)
Update to latest version from linuxserver/docker-qbittorrent
4.4.3.1-r1-ls209 (09-08-2022)
Update to latest version from linuxserver/docker-qbittorrent
4.4.3.1-r1-ls208 (04-08-2022)
Update to latest version from linuxserver/docker-qbittorrent
4.4.3.1-r1-ls207 (26-07-2022)
Update to latest version from linuxserver/docker-qbittorrent
4.4.3.1-r1-ls206 (12-07-2022)
Update to latest version from linuxserver/docker-qbittorrent
4.4.3.1-r1-ls205 (05-07-2022)
Update to latest version from linuxserver/docker-qbittorrent
Default port changed from 6881 to 59595 ; reset your port settings if it doesn't change
4.4.3.1-r1-ls204 (18-06-2022)
Update to latest version from linuxserver/docker-qbittorrent
4.4.3.1-r1-ls201 (14-06-2022)
Update to latest version from linuxserver/docker-qbittorrent
Addition of optional noserverino in smb mount code
4.4.3.1-r1-ls200 (06-06-2022)
Update to latest version from linuxserver/docker-qbittorrent
4.4.3.1-r1-ls199 (02-06-2022)
Update to latest version from linuxserver/docker-qbittorrent
4.4.3.1-r0-ls198 (31-05-2022)
Update to latest version from linuxserver/docker-qbittorrent
4.4.3-r0-ls197 (26-05-2022)
Update to latest version from linuxserver/docker-qbittorrent
4.4.3-r0-ls195 (24-05-2022)
Update to latest version from linuxserver/docker-qbittorrent
4.4.2-r5-ls193 (17-05-2022)
Update to latest version from linuxserver/docker-qbittorrent
4.4.2-r4-ls191 (10-05-2022)
Update to latest version from linuxserver/docker-qbittorrent
Feature : message in log showing if vpn alt mode is working
4.4.2-r4-ls190 (03-05-2022)
Update to latest version from linuxserver/docker-qbittorrent
4.4.2-r4-ls189 (27-04-2022)
Update to latest version from linuxserver/docker-qbittorrent
New feature "silent" : true shows only error messages of qbittorrent and nginx
New feature "openvpn_alt_mode": bind at container level and not app level
Add codenotary sign
Fix openvpn interface bind
Fix qb-web custom ui
Fix download folder
release-4.4.1-ls172 (20-02-2022)
Update to latest version from linuxserver/docker-qbittorrent
Complete rebase to alpine
Fix custom DNS
Host header validation disabled (avoids ingress issues)
Removed openvpn_alternative_mode (please delete from config), now default
Changed openvpn mode to interface binding (no ip leakage)
14.3.9.99202110311443-7435-01519b5e7ubuntu20.04.1-ls166 (07-01-2022)
Update to latest version from linuxserver/docker-qbittorrent
14.3.9.99202110311443-7435-01519b5e7ubuntu20.04.1-ls165 (04-01-2022)
Update to latest version from linuxserver/docker-qbittorrent
Removed watchdog
New standardized logic for Dockerfile build and packages installation
Allow mounting nvme
Allow mounting local drives by label. Just pust the label instead of sda1 for example
14.3.9.99202110311443-7435-01519b5e7ubuntu20.04.1-ls159 (31-10-2021)
Update to latest version from linuxserver/docker-qbittorrent
SMB : accepts several disks separated by commas mounted in /mnt/$sharename
14.3.8.99202110120741-7429-1bae770b2ubuntu20.04.1-ls158 (13-10-2021)
Update to latest version from linuxserver/docker-qbittorrent
Added watchdog feature
14.3.8.99202110081405-7423-ac5c264e6ubuntu20.04.1-ls157 (08-10-2021)
Update to latest version from linuxserver/docker-qbittorrent
Allow mounting local drives. Set "localdisks" to your disk name such as sda1
Added auto stop, just set the run_duration optional setting
14.3.8.99202109100310-7422-338d9a084ubuntu20.04.1-ls154 (10-09-2021)
Update to latest version from linuxserver/docker-qbittorrent
14.3.8.99202108291924-7418-9392ce436ubuntu20.04.1-ls152 (31-08-2021)
Update to latest version from linuxserver/docker-qbittorrent
14.3.7.99202108230857-7410-fefce0337ubuntu20.04.1-ls151 (24-08-2021)
Update to latest version from linuxserver/docker-qbittorrent
14.3.7.99202108032349-7395-0415c0c6fubuntu20.04.1-ls149 (05-08-2021)
Update to latest version from linuxserver/docker-qbittorrent
Improved smb mount code
14.3.6.99202107121017-7389-3ac8c97e6ubuntu20.04.1-ls145 (13-07-2021)
Update to latest version from linuxserver/docker-qbittorrent
14.3.6.99202107050919-7388-ede42910dubuntu20.04.1-ls143 (05-07-2021)
Update to latest version from linuxserver/docker-qbittorrent
14.3.6.99202106272003-7387-ac8105c30ubuntu20.04.1-ls141 (28-06-2021)
Update to latest version from linuxserver/docker-qbittorrent
14.3.5.99202106211645-7376-e25948e73ubuntu20.04.1-ls140 (22-06-2021)
Update to latest version from linuxserver/docker-qbittorrent
14.3.5.99202106201814-7376-e25948e73ubuntu20.04.1-ls139 (21-06-2021)
Update to latest version from linuxserver/docker-qbittorrent
14.3.5.99202106191735-7376-e25948e73ubuntu20.04.1-ls138 (20-06-2021)
Update to latest version from linuxserver/docker-qbittorrent
14.3.5.99202106151345-7374-667d4e421ubuntu20.04.1-ls137 (16-06-2021)
Update to latest version from linuxserver/docker-qbittorrent
14.3.5.99202106080759-7366-33e090cfcubuntu20.04.1-ls136 (09-06-2021)
Update to latest version from linuxserver/docker-qbittorrent
Add banner in log
New option openvpn_alternative_mode, binds only ovpn to qbittorrent and not webui
14.3.5.99202105022253-7365-063844ed4ubuntu20.04.1-ls133 (11-05-2021)
Update to latest version from linuxserver/docker-qbittorrent
14.3.5.99202105022253-7365-063844ed4ubuntu20.04.1-ls132 (04-05-2021)
Update to latest version from linuxserver/docker-qbittorrent
New option : use specific DNS instead of the router ones to avoid spamming, especially useful if using adguard home/pihole. Keep blank to use the router dns.
14.3.4.99202104300534-7354-9f8a6e8fbubuntu20.04.1-ls131 (01-05-2021)
Update to latest version from linuxserver/docker-qbittorrent
Robust the smb script to test for several common options
smbv1 bit is not used anymore
14.3.4.99202104281424-7353-7dd9e7343ubuntu20.04.1-ls130 (29-04-2021)
Update to latest version from linuxserver/docker-qbittorrent
14.3.4.99202104250604-7352-b2a43eeffubuntu20.04.1-ls129 (27-04-2021)
Update to latest version from linuxserver/docker-qbittorrent
14.3.4.99202104250604-7352-b2a43eeffubuntu20.04.1-ls128
Update to latest version from linuxserver/docker-qbittorrent
Clarified steps to check in case of smb mount fail
New option : set domain for smb share
Addition of openvpn support
14.3.4.99202104180633-7350-2c8f322afubuntu20.04.1-ls127
Update to latest version from linuxserver/docker-qbittorrent
14.3.4.99202104090418-7349-789803700ubuntu20.04.1-ls126
Update to latest version from linuxserver/docker-qbittorrent
Addition of ingress
Viewtorrent as default ui
14.3.4.99202104031018-7348-2b6baa609ubuntu20.04.1-ls125
Update to latest version from linuxserver/docker-qbittorrent
14.3.3.99202103251603-7345-332b173e0ubuntu20.04.1-ls122
Update to latest version from linuxserver/docker-qbittorrent ; Rebase to focal.
14.3.3.99202101191832-7248-da0b276d5ubuntu20.04.1-ls120
Update to latest version from linuxserver/docker-qbittorrent ; Stop creating /config/data directory on startup
14.3.3.99202101191832-7248-da0b276d5ubuntu20.04.1-ls119
Update to latest version from linuxserver/docker-qbittorrent ; Fix adding search engine plugin
14.3.3.99202101191832-7248-da0b276d5ubuntu20.04.1-ls118
Update to latest version from linuxserver/docker-qbittorrent
Allow mounting shares named \ip\share in addition to //ip/share
14.3.3.99202101191832-7248-da0b276d5ubuntu20.04.1-ls117
Update to latest version from linuxserver/docker-qbittorrent
14.3.3.99202101191832-7248-da0b276d5ubuntu20.04.1-ls116
Correct VueTorrent link
14.3.3.99202101191832-7248-da0b276d5ubuntu20.04.1-ls115
New configuration option : set download path
New configuration option : set username for webUI
New feature : mount smb share in protected mode
New feature : mount multiple smb shares
New config/feature : mount smbv1
Changed path : changed smb mount path from /storage/externalcifs to /mnt/$NAS name
Removed feature : ability to remove protection and mount local hdd, to increase the addon score
Update to latest version from linuxserver/docker-qbittorrent
Enabling of custom webUI from configuration
14.3.3.99202101191832-7248-da0b276d5ubuntu18.04.1-ls114
Update to latest version from linuxserver/docker-qbittorrent
14.3.3.99202101191832-7248-da0b276d5ubuntu18.04.1-ls113
Update to latest version from linuxserver/docker-qbittorrent
Whitelist option
Enables PUID/PGID options
Addition of ssl options
Addition of possibility to mount local disc or smb
Tienes instalada la 4.4.5-r0-ls214-2-bugfix. Haz clic en actualizar para actualizar a la versión 4.4.5-r0-ls214-2-bugfix2

Sin título

alexbelgium commented 2 years ago

Thanks! Should be good now :) hopefully

txitxo0 commented 2 years ago

Uauuuu you are so kind to be so much faster than ligth! thank you, it is already working now :)

alexbelgium commented 2 years ago

Thanks for the feedback! Happy it works! It was a global code so this avoids all users on supervised to have this bug on all addons :) thanks for the testings and log!