alexbelgium / hassio-addons

My homeassistant addons
MIT License
1.58k stars 226 forks source link

🐛 [unpackerr] New upstream image overwritten #653

Closed nathang21 closed 1 year ago

nathang21 commented 1 year ago

Which addon?

Describe the bug

Not directly a bug, but a report of a potential unintended change. According to the CHANGELOG, on 0.10.1-2 (08-10-2022) the upstream image was changed to hotio/unpackerr.

However since then, it appears to have switched back to davidnewhall/unpackerr in the updater.json via this commit, which is now causing all future auto-updates to use the former upstream image.

I don't remember the context of why the image was changed, but from the commit history it's not clear if the revert back was intentional or not.

To Reproduce

N/A

Full addon log

s6-rc: info: service s6rc-oneshot-runner: starting
s6-rc: info: service s6rc-oneshot-runner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service legacy-cont-init: starting
cont-init: info: running /etc/cont-init.d/00-banner.sh
-----------------------------------------------------------
 Add-on: Unpackerr
 Unpacks RARd files for Sonarr, Lidarr and Radarr
-----------------------------------------------------------
 Add-on version: 0.11.1
 You are running the latest version of this add-on.
 System: Home Assistant OS 9.4  (aarch64 / odroid-n2)
 Home Assistant Core: 2023.1.6
 Home Assistant Supervisor: 2022.12.1
-----------------------------------------------------------
 Please, share the above information when looking for help
 or support in, e.g., GitHub, forums
 https://github.com/alexbelgium/hassio-addons
-----------------------------------------------------------
cont-init: info: /etc/cont-init.d/00-banner.sh exited 0
cont-init: info: running /etc/cont-init.d/00-env-file-init
cont-init: info: /etc/cont-init.d/00-env-file-init exited 0
cont-init: info: running /etc/cont-init.d/00-start-container
----------------------------------------------------------------------
ENVIRONMENT
----------------------------------------------------------------------
PUID=1000
PGID=1000
UMASK=002
TZ=America/New_York
----------------------------------------------------------------------
Executing usermod...
usermod: no changes
Applying permissions to /config
cont-init: info: /etc/cont-init.d/00-start-container exited 0
cont-init: info: running /etc/cont-init.d/01-configure-app
cont-init: info: /etc/cont-init.d/01-configure-app exited 0
cont-init: info: running /etc/cont-init.d/01-custom_script.sh
[11:33:29] INFO: Execute /config/addons_autoscripts/unpackerr.sh if existing
[11:33:29] INFO: ... no script found
cont-init: info: /etc/cont-init.d/01-custom_script.sh exited 0
cont-init: info: running /etc/cont-init.d/92-local_mounts.sh
cont-init: info: /etc/cont-init.d/92-local_mounts.sh exited 0
cont-init: info: running /etc/cont-init.d/92-smb_mounts.sh
cont-init: info: /etc/cont-init.d/92-smb_mounts.sh exited 0
cont-init: info: running /etc/cont-init.d/99-config.sh
cont-init: info: /etc/cont-init.d/99-config.sh exited 0
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
services-up: info: copying legacy longrun unpackerr (no readiness notification)
2023/01/21 11:33:30.996619 start.go:129: Unpackerr v0.11.1 Starting! PID: 288, UID: 1000, GID: 1000, Now: 2023-01-21 11:33:31 -0500 EST
2023/01/21 11:33:30.996737 logs.go:226: ==> GoLift Discord: https://golift.io/discord <==
2023/01/21 11:33:30.996749 logs.go:227: ==> Startup Settings <==
2023/01/21 11:33:30.996767 sonarr.go:85:  => Sonarr Config: 0 servers
2023/01/21 11:33:30.996775 radarr.go:85:  => Radarr Config: 0 servers
2023/01/21 11:33:30.996785 lidarr.go:85:  => Lidarr Config: 0 servers
2023/01/21 11:33:30.996797 readarr.go:85:  => Readarr Config: 0 servers
2023/01/21 11:33:30.996822 folder.go:70:  => Folder Config: 1 path: /media, extract to: /media (delete after:10m, delete orig:true, log file: true, move back:true, isos:false, event buffer:20000)
2023/01/21 11:33:30.996834 logs.go:234:  => Using Config File: /config/unpackerr.conf
2023/01/21 11:33:30.996841 logs.go:235:  => Parallel: 1
2023/01/21 11:33:30.996848 logs.go:236:  => Passwords: 0 (rar/7z)
2023/01/21 11:33:30.996854 logs.go:237:  => Interval: 5m
2023/01/21 11:33:30.996860 logs.go:238:  => Start Delay: 5m
2023/01/21 11:33:30.996867 logs.go:239:  => Retry Delay: 5m, max: 3
2023/01/21 11:33:30.996873 logs.go:240:  => Debug / Quiet: true / false
2023/01/21 11:33:30.996879 logs.go:241:  => Activity / Queues: false / 5m
2023/01/21 11:33:30.996886 logs.go:244:  => Directory & File Modes: 0755 & 0644
2023/01/21 11:33:30.996893 webhook.go:228:  => Webhook Configs: 0 URLs
2023/01/21 11:33:30.996901 cmdhook.go:124:  => Command Hook Configs: 0 cmds
2023/01/21 11:33:30.997710 folder.go:113: [Folder] Watching (fsnotify): /media
2023/01/21 11:33:30.997763 folder.go:124: [Folder] Polling @ 1s: /media
s6-rc: info: service legacy-services successfully started
2023/01/21 11:38:30.997284 logs.go:159: [Unpackerr] Queue: [0 waiting] [0 queued] [0 extracting] [0 extracted] [0 imported] [0 failed] [0 deleted]
2023/01/21 11:38:30.997334 logs.go:161: [Unpackerr] Totals: [0 retries] [0 finished] [0|0 webhooks] [0|0 cmdhooks] [stacks; event:0, hook:0, del:0]

Full addon config

PGID: 1000
PUID: 1000
extraction_path: /media
watch_path: /media

System

Home Assistant 2023.1.6 Supervisor 2022.12.1 Operating System 9.4 Frontend 20230110.0 - latest

alexbelgium commented 1 year ago

Thanks; I see what happened. So, the image is still built using "hotio/unpackerr:latest", which had the advantage of being based on s6 and allowed easier image customization. However the dockerhub versioning is super strange. I had linked the upgrade system to "davidnewhall/unpackerr" because I preferred he's release nomenclature. I do see how that can be confusing, and I'll try to align updater.json with hotio; we'll see what happens.

Have a nice day!

Le sam. 21 janv. 2023 à 17:44, Nathan Guenther @.***> a écrit :

Which addon?

  • Addon name : unpackerr
  • Addon version : 0.11.1

Describe the bug

Not directly a bug, but a report of a potential unintended change. According to the CHANGELOG https://github.com/alexbelgium/hassio-addons/blob/master/unpackerr/CHANGELOG.md, on 0.10.1-2 (08-10-2022) the upstream image was changed to hotio/unpackerr .

However since then, it appears to have switched back to davidnewhall/unpackerr in the updater.json via this commit https://github.com/alexbelgium/hassio-addons/commit/9e98e2cfad93963c4574b5ec6078511dc938bc2a, which is now causing all future auto-updates to use the former upstream image.

I don't remember the context of why the image was changed, but from the commit history it's not clear if the revert back was intentional or not.

To Reproduce

N/A

Full addon log

s6-rc: info: service s6rc-oneshot-runner: starting s6-rc: info: service s6rc-oneshot-runner successfully started s6-rc: info: service fix-attrs: starting s6-rc: info: service fix-attrs successfully started s6-rc: info: service legacy-cont-init: starting cont-init: info: running /etc/cont-init.d/00-banner.sh

Add-on: Unpackerr Unpacks RARd files for Sonarr, Lidarr and Radarr

Add-on version: 0.11.1 You are running the latest version of this add-on. System: Home Assistant OS 9.4 (aarch64 / odroid-n2) Home Assistant Core: 2023.1.6 Home Assistant Supervisor: 2022.12.1

Please, share the above information when looking for help or support in, e.g., GitHub, forums https://github.com/alexbelgium/hassio-addons

cont-init: info: /etc/cont-init.d/00-banner.sh exited 0 cont-init: info: running /etc/cont-init.d/00-env-file-init cont-init: info: /etc/cont-init.d/00-env-file-init exited 0 cont-init: info: running /etc/cont-init.d/00-start-container

ENVIRONMENT

PUID=1000 PGID=1000 UMASK=002 TZ=America/New_York

Executing usermod... usermod: no changes Applying permissions to /config cont-init: info: /etc/cont-init.d/00-start-container exited 0 cont-init: info: running /etc/cont-init.d/01-configure-app cont-init: info: /etc/cont-init.d/01-configure-app exited 0 cont-init: info: running /etc/cont-init.d/01-custom_script.sh [11:33:29] INFO: Execute /config/addons_autoscripts/unpackerr.sh if existing [11:33:29] INFO: ... no script found cont-init: info: /etc/cont-init.d/01-custom_script.sh exited 0 cont-init: info: running /etc/cont-init.d/92-local_mounts.sh cont-init: info: /etc/cont-init.d/92-local_mounts.sh exited 0 cont-init: info: running /etc/cont-init.d/92-smb_mounts.sh cont-init: info: /etc/cont-init.d/92-smb_mounts.sh exited 0 cont-init: info: running /etc/cont-init.d/99-config.sh cont-init: info: /etc/cont-init.d/99-config.sh exited 0 s6-rc: info: service legacy-cont-init successfully started s6-rc: info: service legacy-services: starting services-up: info: copying legacy longrun unpackerr (no readiness notification) 2023/01/21 11:33:30.996619 start.go:129: Unpackerr v0.11.1 Starting! PID: 288, UID: 1000, GID: 1000, Now: 2023-01-21 11:33:31 -0500 EST 2023/01/21 11:33:30.996737 logs.go:226: ==> GoLift Discord: https://golift.io/discord <== 2023/01/21 11:33:30.996749 logs.go:227: ==> Startup Settings <== 2023/01/21 11:33:30.996767 sonarr.go:85: => Sonarr Config: 0 servers 2023/01/21 11:33:30.996775 radarr.go:85: => Radarr Config: 0 servers 2023/01/21 11:33:30.996785 lidarr.go:85: => Lidarr Config: 0 servers 2023/01/21 11:33:30.996797 readarr.go:85: => Readarr Config: 0 servers 2023/01/21 11:33:30.996822 folder.go:70: => Folder Config: 1 path: /media, extract to: /media (delete after:10m, delete orig:true, log file: true, move back:true, isos:false, event buffer:20000) 2023/01/21 11:33:30.996834 logs.go:234: => Using Config File: /config/unpackerr.conf 2023/01/21 11:33:30.996841 logs.go:235: => Parallel: 1 2023/01/21 11:33:30.996848 logs.go:236: => Passwords: 0 (rar/7z) 2023/01/21 11:33:30.996854 logs.go:237: => Interval: 5m 2023/01/21 11:33:30.996860 logs.go:238: => Start Delay: 5m 2023/01/21 11:33:30.996867 logs.go:239: => Retry Delay: 5m, max: 3 2023/01/21 11:33:30.996873 logs.go:240: => Debug / Quiet: true / false 2023/01/21 11:33:30.996879 logs.go:241: => Activity / Queues: false / 5m 2023/01/21 11:33:30.996886 logs.go:244: => Directory & File Modes: 0755 & 0644 2023/01/21 11:33:30.996893 webhook.go:228: => Webhook Configs: 0 URLs 2023/01/21 11:33:30.996901 cmdhook.go:124: => Command Hook Configs: 0 cmds 2023/01/21 11:33:30.997710 folder.go:113: [Folder] Watching (fsnotify): /media 2023/01/21 11:33:30.997763 folder.go:124: [Folder] Polling @ 1s: /media s6-rc: info: service legacy-services successfully started 2023/01/21 11:38:30.997284 logs.go:159: [Unpackerr] Queue: [0 waiting] [0 queued] [0 extracting] [0 extracted] [0 imported] [0 failed] [0 deleted] 2023/01/21 11:38:30.997334 logs.go:161: [Unpackerr] Totals: [0 retries] [0 finished] [0|0 webhooks] [0|0 cmdhooks] [stacks; event:0, hook:0, del:0]

Full addon config

PGID: 1000 PUID: 1000 extraction_path: /media watch_path: /media

System

Home Assistant 2023.1.6 Supervisor 2022.12.1 Operating System 9.4 Frontend 20230110.0 - latest

— Reply to this email directly, view it on GitHub https://github.com/alexbelgium/hassio-addons/issues/653, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKRB2GNL7CA4H7P4S2RHX4LWTQG7NANCNFSM6AAAAAAUCPNJUI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

alexbelgium commented 1 year ago

Should be good now, but as you can see the addon naming is now quite weird