alexbelgium / hassio-addons

My homeassistant addons
MIT License
1.57k stars 224 forks source link

✨ [REQUEST] Sonarr develop #866

Open JonasTae opened 1 year ago

JonasTae commented 1 year ago

Checked

Which addon?

The development branch of sonarr. Tag :develop on linuxserver.io

Is your feature request related to a problem? Please describe

The already existing sonarr addon is the version from 19/03/2023. With version 4 several improvements were added. Those changes help a lot with non english and english content mixed in one database.

Describe the solution you'd like

Additional to the sonarr_nas addon there coud be an sonarr_nas_develop oder sonarr_nas_v4 addon.

Maybe others are interested in this too. Thanks!

alexbelgium commented 1 year ago

Hi, I prefer not to duplicate add-ons but can switch the whole add-on. Is the switch a straightforward one, will it lead to data loss for users? Thanks!

derailius commented 1 year ago

this would be outstanding!

derailius commented 1 year ago

Hi, I prefer not to duplicate add-ons but can switch the whole add-on. Is the switch a straightforward one, will it lead to data loss for users? Thanks!

https://forums.sonarr.tv/t/sonarr-v4-beta/31078

we recommend creating a backup of Sonarr v3 and keeping it in a safe location to ensure everything is working as you will not be able to downgrade to v3 without using a backup from v3 or starting with a new DB. Sonarr v4 will automatically upgrade the database from v3 to v4 when it’s run for the first time.

alexbelgium commented 1 year ago

I can make a test version and you tell me how it goes :)

derailius commented 1 year ago

I can make a test version and you tell me how it goes :) no problem, and thank you

alexbelgium commented 1 year ago

I've just pushed a test version it should finish building in a couple minutes

pbvdven commented 1 year ago

Please don't switch v3 to a beta v4.

alexbelgium commented 1 year ago

Why? I've put a message in the changelog saying not to update so if it goes wrong we can still revert the add-on to v3

alexbelgium commented 1 year ago

@derailius if you install the test version I'll revert to v3 if the rest of the community prefers. But then you'll be stuck on v4 unless restoring a backup. Just people let me know if we should keep v3 or move to v4 if it works

derailius commented 1 year ago

ok, thank you @alexbelgium

pbvdven commented 1 year ago

V4 is still beta and has unfixed issues. Also you cant ask one person to test it for every one. I would love to test it as well but can do it not earlier then tomorrow.

alexbelgium commented 1 year ago

Well honestly I'm not using it so I don't really care if it's v3 or v4 so just let me know on which base I should put the add-on ;) I've reverted the add-on so there is no one updating without meaning to and getting stuck on a v4 database

derailius commented 1 year ago

the best option would be to just have a duplicate add-on, but i can see where this would be bothersome. anyway, thank you for your efforts @alexbelgium I truly appreciate you.