search

alexbelgium / hassio-addons

My homeassistant addons
MIT License
1.51k stars 214 forks source link

🐛 [Epic Games Free] Update cron job time #888

Closed ping-localhost closed 1 year ago

ping-localhost commented 1 year ago

Description

Since the latest 5.0 version, it is recommend to run the cron job every 0 0/6 * * * instead of 5 16 * * * (which is the current default).

Since the cron job setting is not available in the configuration, I am creating this bug report.

Reproduction steps

1. Start the addon.
2. There is a warning in the logs.

Addon Logs

[2023-06-30 18:12:40.981 +0200] WARN: Your cronSchedule configuration is not set to run often enough to ensure the device auth refresh token can stay valid. This can result in device auth login prompts being sent on every run. It is recommended to set the cron schedule to run every 6 hours.
    yourCronSchedule: "5 16 * * *"
    everySixCronSchedule: "0 0/6 * * *"

Architecture

No response

OS

No response

alexbelgium commented 1 year ago

Hi, thanks. Actually I don't set the cron job in my add-on so this is likely done in the upstream container charlocharlie/epicgames-freegames:latest

I'll check it to see if they are emitting a new version

alexbelgium commented 1 year ago

Actually you're right one updated my template but you need to edit your config file in /config/addons_config/epicgamesfree

I've added in the changelog a link to the migration v4 to v5 that needs to be performed by individual users

Thanks!

ping-localhost commented 1 year ago

Ah yes, thank you. I've updated mine now as well. Closing this issue. :)