search

alexbevi / redmine_knowledgebase

A knowledgebase plugin for Redmine
453 stars 197 forks source link

Access to article is not restricted #302

Closed pyhalov closed 6 years ago

pyhalov commented 8 years ago

When I create unprivileged user, he can go to "Knowledgebase" project tab and see categories. Main page says that he doesn't have permission to view articles or categories. However, he can choose articles category in menu at top right corner of the page and see articles in the category or use direct links (like projects/project1/knowledgebase/articles/11

robspearman commented 8 years ago

Can you confirm you have removed all knowledgebase permissions for the role for this user?

I am testing on my own fork, but I can only reproduce this if I create non-sensical permission sets like can not view articles but can edit them, etc. With no permissions at all the user can not see the tab nor view articles with a direct link.

alexbevi commented 8 years ago

@robspearman: @pyhalov has a patch at https://github.com/pyhalov/redmine_knowledgebase/commit/0d2808f9f89140f504e11b7772dd89528335d368. Does this look decent?

pyhalov commented 8 years ago

at least it works for us

alexbevi commented 8 years ago

@pyhalov i'll likely end up merging this when i do 3.2.1. was just looking for feedback ;)

robspearman commented 6 years ago

Issue should now be fixed.