search

alexbevi / redmine_knowledgebase

A knowledgebase plugin for Redmine
452 stars 199 forks source link

Quickfix, replaces thumbnail_url with polymorphic_url #394

Closed wiesion closed 1 year ago

wiesion commented 3 years ago

As described in https://github.com/rails/rails/pull/15840 - *_path methods should not be allowed within Mailer actions.

The original code is in fact constructing an absolute URL, but is doing so by making using of a *_path method. This is fine for web and data views, but not for Mailer views.

Rails' polymorphic_url exists since Version 2 and its syntax experienced no changes, so i assume it should be a backward compatible replacement.

wiesion commented 3 years ago

This should also address the issues #383 and #388.

lauer commented 1 year ago

thy not just use return thumbnail_url(thumb) that works fine for me?

alexbevi commented 1 year ago

Closing this in favour of #406