search

alexbol99 / flatten-js

Javascript library for 2d geometry
MIT License
546 stars 56 forks source link

add types to Inversion.inverse parameters #101

Closed joelrbrandt closed 2 years ago

joelrbrandt commented 2 years ago

With v1.3.0, I'm getting TypeScript build failures when noImplicitAny is set to true.

node_modules/@flatten-js/core/index.d.ts:549:17 - error TS7006: Parameter 'Point' implicitly has an 'any' type.

549         inverse(Point) : Point;
                    ~~~~~

node_modules/@flatten-js/core/index.d.ts:550:17 - error TS7006: Parameter 'Line' implicitly has an 'any' type.

550         inverse(Line) : Line | Circle;
                    ~~~~

node_modules/@flatten-js/core/index.d.ts:551:17 - error TS7006: Parameter 'Circle' implicitly has an 'any' type.

551         inverse(Circle) : Line | Circle;

This PR adds explicit type annotations to the parameters for Inversion.inverse

Thanks for your hard work on this package!

alexbol99 commented 2 years ago

Thank you, Joel, for your contribution to this package. I could work harder if I would understand better where I can take this project. Do you have any ideas? What is lack to make it more valuable? Thanks, Alex.